From 1cc58ea150a875801998a6bd6412c069941ab5e0 Mon Sep 17 00:00:00 2001 From: Shaun Walker Date: Fri, 18 Oct 2019 12:23:36 -0400 Subject: [PATCH] performance optimizations in site router and remove dependency between page and module in route specification --- .../Modules/Admin/Dashboard/Index.razor | 8 +- Oqtane.Client/Modules/Admin/Files/Add.razor | 5 +- Oqtane.Client/Modules/Admin/Files/Index.razor | 2 +- .../Modules/Admin/ModuleDefinitions/Add.razor | 5 +- Oqtane.Client/Modules/Admin/Themes/Add.razor | 5 +- .../Modules/Admin/Upgrade/Index.razor | 5 +- Oqtane.Client/Modules/HtmlText/Edit.razor | 4 +- Oqtane.Client/Services/FileService.cs | 14 ++- .../Services/Interfaces/IFileService.cs | 2 +- .../Services/Interfaces/IModuleService.cs | 3 +- Oqtane.Client/Services/ModuleService.cs | 10 +- Oqtane.Client/Shared/Pane.razor | 2 +- Oqtane.Client/Shared/SiteRouter.razor | 108 ++++++++++-------- .../Themes/Controls/ControlPanel.razor | 64 +++++------ Oqtane.Server/Controllers/ModuleController.cs | 52 ++++----- .../Interfaces/IModuleRepository.cs | 1 - .../Interfaces/IPageModuleRepository.cs | 2 +- Oqtane.Server/Repository/ModuleRepository.cs | 13 --- .../Repository/PageModuleRepository.cs | 7 +- Oqtane.Server/Repository/SiteRepository.cs | 32 +++--- Oqtane.Shared/Models/PageTemplate.cs | 1 - Oqtane.Shared/Shared/Constants.cs | 2 + 22 files changed, 172 insertions(+), 175 deletions(-) diff --git a/Oqtane.Client/Modules/Admin/Dashboard/Index.razor b/Oqtane.Client/Modules/Admin/Dashboard/Index.razor index b7084f19..a0ad0257 100644 --- a/Oqtane.Client/Modules/Admin/Dashboard/Index.razor +++ b/Oqtane.Client/Modules/Admin/Dashboard/Index.razor @@ -17,15 +17,15 @@ } } -
-
@code { + public override SecurityAccessLevel SecurityAccessLevel { get { return SecurityAccessLevel.Admin; } } + List pages; protected override void OnInitialized() { - // display list of pages which are children of current page - pages = PageState.Pages.Where(item => item.ParentId == PageState.Page.PageId).ToList(); + Page admin = PageState.Pages.Where(item => item.Path == "admin").FirstOrDefault(); + pages = PageState.Pages.Where(item => item.ParentId == admin.PageId).ToList(); } } diff --git a/Oqtane.Client/Modules/Admin/Files/Add.razor b/Oqtane.Client/Modules/Admin/Files/Add.razor index ffe3edcb..fca41914 100644 --- a/Oqtane.Client/Modules/Admin/Files/Add.razor +++ b/Oqtane.Client/Modules/Admin/Files/Add.razor @@ -30,13 +30,14 @@ { ShowProgressIndicator(); - if (await FileService.UploadFilesAsync(PageState.Site.SiteRootPath, files, "")) + string result = await FileService.UploadFilesAsync(PageState.Site.SiteRootPath, files, ""); + if (result == "") { AddModuleMessage("Files Uploaded Successfully", MessageType.Success); } else { - AddModuleMessage("Upload Failed", MessageType.Error); + AddModuleMessage("Upload Failed For " + result.Replace(",",", ") + ". This Could Be Due To A Network Error Or Because A File Type Is Restricted.", MessageType.Error); } } catch (Exception ex) diff --git a/Oqtane.Client/Modules/Admin/Files/Index.razor b/Oqtane.Client/Modules/Admin/Files/Index.razor index eb07e32d..b73936b8 100644 --- a/Oqtane.Client/Modules/Admin/Files/Index.razor +++ b/Oqtane.Client/Modules/Admin/Files/Index.razor @@ -9,7 +9,7 @@ } else { - +
diff --git a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor index cf7fd55e..810ae6c7 100644 --- a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor +++ b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor @@ -74,7 +74,8 @@ { try { - if (await FileService.UploadFilesAsync("Modules", files, "")) + string result = await FileService.UploadFilesAsync("Modules", files, ""); + if (result == "") { AddModuleMessage("Module Uploaded Successfully. Click Install To Complete Installation.", MessageType.Success); uploaded = true; @@ -82,7 +83,7 @@ } else { - AddModuleMessage("Module Upload Failed.", MessageType.Error); + AddModuleMessage("Upload Failed For " + result.Replace(",",", ") + ". This Could Be Due To A Network Error Or Because A File Type Is Restricted.", MessageType.Error); } } catch (Exception ex) diff --git a/Oqtane.Client/Modules/Admin/Themes/Add.razor b/Oqtane.Client/Modules/Admin/Themes/Add.razor index dd60562b..aad68ca5 100644 --- a/Oqtane.Client/Modules/Admin/Themes/Add.razor +++ b/Oqtane.Client/Modules/Admin/Themes/Add.razor @@ -73,7 +73,8 @@ { try { - if (await FileService.UploadFilesAsync("Themes", files, "")) + string result = await FileService.UploadFilesAsync("Themes", files, ""); + if (result == "") { AddModuleMessage("Theme Uploaded Successfully. Click Install To Complete Installation.", MessageType.Success); uploaded = true; @@ -81,7 +82,7 @@ } else { - AddModuleMessage("Theme Upload Failed.", MessageType.Error); + AddModuleMessage("Upload Failed For " + result.Replace(",",", ") + ". This Could Be Due To A Network Error Or Because A File Type Is Restricted.", MessageType.Error); } } catch (Exception ex) diff --git a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor index e6fe6e56..827069e2 100644 --- a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor +++ b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor @@ -62,7 +62,8 @@ else { try { - if (await FileService.UploadFilesAsync("Framework", files, "")) + string result = await FileService.UploadFilesAsync("Framework", files, ""); + if (result == "") { AddModuleMessage("Framework Uploaded Successfully. Click Upgrade To Complete Installation.", MessageType.Success); uploaded = true; @@ -70,7 +71,7 @@ else } else { - AddModuleMessage("Framework Upload Failed.", MessageType.Error); + AddModuleMessage("Upload Failed For " + result.Replace(",",", ") + ". This Could Be Due To A Network Error Or Because A File Type Is Restricted.", MessageType.Error); } } catch (Exception ex) diff --git a/Oqtane.Client/Modules/HtmlText/Edit.razor b/Oqtane.Client/Modules/HtmlText/Edit.razor index 624ea38b..e1400d6f 100644 --- a/Oqtane.Client/Modules/HtmlText/Edit.razor +++ b/Oqtane.Client/Modules/HtmlText/Edit.razor @@ -6,13 +6,13 @@ @inject HttpClient http @inject SiteState sitestate - +
-