Diplomarbeit-Absolventenverein/oqtane.framework
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4705 from maurocavallin/dev

Browse Source 
Hard deletion of page more robust use of entity framework contexts
This commit is contained in:
Shaun Walker 2024-10-04 17:14:00 -04:00 committed by GitHub
commit 1047058676
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Oqtane.Server/Repository/PageRepository.cs
View File

@ -91,6 +91,7 @@ namespace Oqtane.Repository
public void DeletePage(int pageId) public void DeletePage(int pageId)
{ {
using var db = _dbContextFactory.CreateDbContext(); using var db = _dbContextFactory.CreateDbContext();
{
var page = db.Page.Find(pageId); var page = db.Page.Find(pageId);
_permissions.DeletePermissions(page.SiteId, EntityNames.Page, pageId); _permissions.DeletePermissions(page.SiteId, EntityNames.Page, pageId);
_settings.DeleteSettings(EntityNames.Page, pageId); _settings.DeleteSettings(EntityNames.Page, pageId);
@ -100,9 +101,19 @@ namespace Oqtane.Repository
{ {
_pageModules.DeletePageModule(pageModule.PageModuleId); _pageModules.DeletePageModule(pageModule.PageModuleId);
} }
// must occur after page modules are deleted because of cascading delete relationship
db.Page.Remove(page); // At this point the page item is unaware of changes happened in other
db.SaveChanges(); // contexts (i.e.: the contex opened and closed in each DeletePageModule).
// Workin on page item may result in unxpected behaviour:
// better close and reopen context to work on a fresh page item.
}
using var dbContext = _dbContextFactory.CreateDbContext();
{
var page = dbContext.Page.Find(pageId);
dbContext.Page.Remove(page);
dbContext.SaveChanges();
}
} }
} }
} }