@@ -31,7 +36,10 @@ else
-
+ @if (context.Role.Name != RoleNames.Host)
+ {
+
+ }
|
@@ -57,19 +65,19 @@ else
private List Search(string search)
{
+ var results = allroles.Where(item => item.Role.Name == RoleNames.Registered || (item.Role.Name == RoleNames.Host && UserSecurity.IsAuthorized(PageState.User, RoleNames.Host)));
+
if (string.IsNullOrEmpty(_search))
{
- return allroles.Where(item => item.Role.Name == RoleNames.Registered).ToList();
+ results = results.Where(item =>
+ (
+ item.User.Username.Contains(search, StringComparison.OrdinalIgnoreCase) ||
+ item.User.Email.Contains(search, StringComparison.OrdinalIgnoreCase) ||
+ item.User.DisplayName.Contains(search, StringComparison.OrdinalIgnoreCase)
+ )
+ );
}
- return allroles
- .Where(item => item.Role.Name == RoleNames.Registered &&
- (
- item.User.Username.Contains(search, StringComparison.OrdinalIgnoreCase) ||
- item.User.Email.Contains(search, StringComparison.OrdinalIgnoreCase) ||
- item.User.DisplayName.Contains(search, StringComparison.OrdinalIgnoreCase)
- )
- )
- .ToList();
+ return results.ToList();
}
private async Task OnSearch()
diff --git a/Oqtane.Client/Modules/Admin/Users/Roles.razor b/Oqtane.Client/Modules/Admin/Users/Roles.razor
index 037daabb..03d9e32e 100644
--- a/Oqtane.Client/Modules/Admin/Users/Roles.razor
+++ b/Oqtane.Client/Modules/Admin/Users/Roles.razor
@@ -64,10 +64,10 @@ else
@context.Role.Name |
- @if (context.Role.Name != RoleNames.Registered)
- {
-
- }
+ @if (context.Role.Name != RoleNames.Registered && (context.Role.Name != RoleNames.Host || userid != PageState.User.UserId))
+ {
+
+ }
|
@@ -92,7 +92,14 @@ else
userid = Int32.Parse(PageState.QueryString["id"]);
User user = await UserService.GetUserAsync(userid, PageState.Site.SiteId);
name = user.DisplayName;
- roles = await RoleService.GetRolesAsync(PageState.Site.SiteId);
+ if (UserSecurity.IsAuthorized(PageState.User, RoleNames.Host))
+ {
+ roles = await RoleService.GetRolesAsync(PageState.Site.SiteId, true);
+ }
+ else
+ {
+ roles = await RoleService.GetRolesAsync(PageState.Site.SiteId);
+ }
await GetUserRoles();
}
catch (Exception ex)
@@ -171,9 +178,10 @@ else
await UserRoleService.AddUserRoleAsync(userrole);
}
- await GetUserRoles();
await logger.LogInformation("User Assigned To Role {UserRole}", userrole);
AddModuleMessage(Localizer["User Assigned To Role"], MessageType.Success);
+ await GetUserRoles();
+ StateHasChanged();
}
else
{
@@ -192,9 +200,10 @@ else
try
{
await UserRoleService.DeleteUserRoleAsync(UserRoleId);
- await GetUserRoles();
await logger.LogInformation("User Removed From Role {UserRoleId}", UserRoleId);
AddModuleMessage(Localizer["User Removed From Role"], MessageType.Success);
+ await GetUserRoles();
+ StateHasChanged();
}
catch (Exception ex)
{
diff --git a/Oqtane.Client/Services/Interfaces/IRoleService.cs b/Oqtane.Client/Services/Interfaces/IRoleService.cs
index 23ae0d05..66edc8de 100644
--- a/Oqtane.Client/Services/Interfaces/IRoleService.cs
+++ b/Oqtane.Client/Services/Interfaces/IRoleService.cs
@@ -1,4 +1,4 @@
-using Oqtane.Models;
+using Oqtane.Models;
using System.Collections.Generic;
using System.Threading.Tasks;
@@ -8,6 +8,8 @@ namespace Oqtane.Services
{
Task> GetRolesAsync(int siteId);
+ Task> GetRolesAsync(int siteId, bool includeGlobalRoles);
+
Task GetRoleAsync(int roleId);
Task AddRoleAsync(Role role);
diff --git a/Oqtane.Client/Services/RoleService.cs b/Oqtane.Client/Services/RoleService.cs
index d304edf3..5d29dcd3 100644
--- a/Oqtane.Client/Services/RoleService.cs
+++ b/Oqtane.Client/Services/RoleService.cs
@@ -1,4 +1,4 @@
-using Oqtane.Models;
+using Oqtane.Models;
using System.Threading.Tasks;
using System.Net.Http;
using System.Linq;
@@ -22,7 +22,12 @@ namespace Oqtane.Services
public async Task> GetRolesAsync(int siteId)
{
- List roles = await GetJsonAsync>($"{Apiurl}?siteid={siteId}");
+ return await GetRolesAsync(siteId, false);
+ }
+
+ public async Task> GetRolesAsync(int siteId, bool includeGlobalRoles)
+ {
+ List roles = await GetJsonAsync>($"{Apiurl}?siteid={siteId}&global={includeGlobalRoles}");
return roles.OrderBy(item => item.Name).ToList();
}
diff --git a/Oqtane.Server/Controllers/RoleController.cs b/Oqtane.Server/Controllers/RoleController.cs
index 708e20c3..d04a59cb 100644
--- a/Oqtane.Server/Controllers/RoleController.cs
+++ b/Oqtane.Server/Controllers/RoleController.cs
@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Authorization;
using Oqtane.Enums;
@@ -21,12 +21,16 @@ namespace Oqtane.Controllers
_logger = logger;
}
- // GET: api/?siteid=x
+ // GET: api/?siteid=x&global=true/false
[HttpGet]
[Authorize(Roles = RoleNames.Registered)]
- public IEnumerable Get(string siteid)
+ public IEnumerable Get(string siteid, string global)
{
- return _roles.GetRoles(int.Parse(siteid));
+ if (string.IsNullOrEmpty(global))
+ {
+ global = "false";
+ }
+ return _roles.GetRoles(int.Parse(siteid), bool.Parse(global));
}
// GET api//5
diff --git a/Oqtane.Server/Controllers/UserRoleController.cs b/Oqtane.Server/Controllers/UserRoleController.cs
index 11c875de..437c1e9e 100644
--- a/Oqtane.Server/Controllers/UserRoleController.cs
+++ b/Oqtane.Server/Controllers/UserRoleController.cs
@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Authorization;
using Oqtane.Enums;
@@ -6,6 +6,7 @@ using Oqtane.Models;
using Oqtane.Shared;
using Oqtane.Infrastructure;
using Oqtane.Repository;
+using System.Linq;
namespace Oqtane.Controllers
{
@@ -13,13 +14,15 @@ namespace Oqtane.Controllers
public class UserRoleController : Controller
{
private readonly IUserRoleRepository _userRoles;
+ private readonly IRoleRepository _roles;
private readonly ITenantResolver _tenants;
private readonly ISyncManager _syncManager;
private readonly ILogManager _logger;
- public UserRoleController(IUserRoleRepository userRoles, ITenantResolver tenants, ISyncManager syncManager, ILogManager logger)
+ public UserRoleController(IUserRoleRepository userRoles, IRoleRepository roles, ITenantResolver tenants, ISyncManager syncManager, ILogManager logger)
{
_userRoles = userRoles;
+ _roles = roles;
_syncManager = syncManager;
_tenants = tenants;
_logger = logger;
@@ -46,8 +49,13 @@ namespace Oqtane.Controllers
[Authorize(Roles = RoleNames.Admin)]
public UserRole Post([FromBody] UserRole userRole)
{
- if (ModelState.IsValid)
+ var role = _roles.GetRole(userRole.RoleId);
+ if (ModelState.IsValid && (User.IsInRole(RoleNames.Host) || role.Name != RoleNames.Host))
{
+ if (role.Name == RoleNames.Host)
+ {
+ _userRoles.DeleteUserRoles(userRole.UserId);
+ }
userRole = _userRoles.AddUserRole(userRole);
_syncManager.AddSyncEvent(_tenants.GetTenant().TenantId, EntityNames.User, userRole.UserId);
_logger.Log(LogLevel.Information, this, LogFunction.Create, "User Role Added {UserRole}", userRole);
@@ -60,7 +68,8 @@ namespace Oqtane.Controllers
[Authorize(Roles = RoleNames.Admin)]
public UserRole Put(int id, [FromBody] UserRole userRole)
{
- if (ModelState.IsValid)
+ var role = _roles.GetRole(userRole.RoleId);
+ if (ModelState.IsValid && (User.IsInRole(RoleNames.Host) || role.Name != RoleNames.Host))
{
userRole = _userRoles.UpdateUserRole(userRole);
_syncManager.AddSyncEvent(_tenants.GetTenant().TenantId, EntityNames.User, userRole.UserId);
@@ -75,9 +84,17 @@ namespace Oqtane.Controllers
public void Delete(int id)
{
UserRole userRole = _userRoles.GetUserRole(id);
- _userRoles.DeleteUserRole(id);
- _syncManager.AddSyncEvent(_tenants.GetTenant().TenantId, EntityNames.User, userRole.UserId);
- _logger.Log(LogLevel.Information, this, LogFunction.Delete, "User Role Deleted {UserRole}", userRole);
+ if (User.IsInRole(RoleNames.Host) || userRole.Role.Name != RoleNames.Host)
+ {
+ _userRoles.DeleteUserRole(id);
+ if (userRole.Role.Name == RoleNames.Host)
+ {
+ var role = _roles.GetRoles(_tenants.GetAlias().SiteId).FirstOrDefault(item => item.Name == RoleNames.Registered);
+ _userRoles.AddUserRole(new UserRole { UserId = userRole.UserId, RoleId = role.RoleId, EffectiveDate = null, ExpiryDate = null });
+ }
+ _syncManager.AddSyncEvent(_tenants.GetTenant().TenantId, EntityNames.User, userRole.UserId);
+ _logger.Log(LogLevel.Information, this, LogFunction.Delete, "User Role Deleted {UserRole}", userRole);
+ }
}
}
}
diff --git a/Oqtane.Server/Repository/Interfaces/IUserRoleRepository.cs b/Oqtane.Server/Repository/Interfaces/IUserRoleRepository.cs
index c46a0e50..b26eb5dc 100644
--- a/Oqtane.Server/Repository/Interfaces/IUserRoleRepository.cs
+++ b/Oqtane.Server/Repository/Interfaces/IUserRoleRepository.cs
@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
using Oqtane.Models;
namespace Oqtane.Repository
@@ -11,5 +11,6 @@ namespace Oqtane.Repository
UserRole UpdateUserRole(UserRole userRole);
UserRole GetUserRole(int userRoleId);
void DeleteUserRole(int userRoleId);
+ void DeleteUserRoles(int userId);
}
}
diff --git a/Oqtane.Server/Repository/SiteRepository.cs b/Oqtane.Server/Repository/SiteRepository.cs
index b376b470..f3974ba8 100644
--- a/Oqtane.Server/Repository/SiteRepository.cs
+++ b/Oqtane.Server/Repository/SiteRepository.cs
@@ -649,9 +649,9 @@ namespace Oqtane.Repository
_roleRepository.AddRole(new Role {SiteId = site.SiteId, Name = RoleNames.Admin, Description = "Site Administrators", IsAutoAssigned = false, IsSystem = true});
_profileRepository.AddProfile(new Profile
- {SiteId = site.SiteId, Name = "FirstName", Title = "First Name", Description = "Your First Or Given Name", Category = "Name", ViewOrder = 1, MaxLength = 50, DefaultValue = "", IsRequired = true, IsPrivate = false});
+ {SiteId = site.SiteId, Name = "FirstName", Title = "First Name", Description = "Your First Or Given Name", Category = "Name", ViewOrder = 1, MaxLength = 50, DefaultValue = "", IsRequired = false, IsPrivate = false});
_profileRepository.AddProfile(new Profile
- {SiteId = site.SiteId, Name = "LastName", Title = "Last Name", Description = "Your Last Or Family Name", Category = "Name", ViewOrder = 2, MaxLength = 50, DefaultValue = "", IsRequired = true, IsPrivate = false});
+ {SiteId = site.SiteId, Name = "LastName", Title = "Last Name", Description = "Your Last Or Family Name", Category = "Name", ViewOrder = 2, MaxLength = 50, DefaultValue = "", IsRequired = false, IsPrivate = false});
_profileRepository.AddProfile(new Profile
{SiteId = site.SiteId, Name = "Street", Title = "Street", Description = "Street Or Building Address", Category = "Address", ViewOrder = 3, MaxLength = 50, DefaultValue = "", IsRequired = false, IsPrivate = false});
_profileRepository.AddProfile(
diff --git a/Oqtane.Server/Repository/UserRoleRepository.cs b/Oqtane.Server/Repository/UserRoleRepository.cs
index b47bd6f7..d62156f5 100644
--- a/Oqtane.Server/Repository/UserRoleRepository.cs
+++ b/Oqtane.Server/Repository/UserRoleRepository.cs
@@ -58,5 +58,14 @@ namespace Oqtane.Repository
_db.UserRole.Remove(userRole);
_db.SaveChanges();
}
+
+ public void DeleteUserRoles(int userId)
+ {
+ foreach (UserRole userRole in _db.UserRole.Where(item => item.Role.SiteId != null))
+ {
+ _db.UserRole.Remove(userRole);
+ }
+ _db.SaveChanges();
+ }
}
}
|