Fix naming conventions for private fields
This commit is contained in:
@ -13,19 +13,19 @@ namespace Oqtane.Controllers
|
||||
[Route("{site}/api/[controller]")]
|
||||
public class PageController : Controller
|
||||
{
|
||||
private readonly IPageRepository Pages;
|
||||
private readonly IModuleRepository Modules;
|
||||
private readonly IPageModuleRepository PageModules;
|
||||
private readonly IUserPermissions UserPermissions;
|
||||
private readonly ILogManager logger;
|
||||
private readonly IPageRepository _pages;
|
||||
private readonly IModuleRepository _modules;
|
||||
private readonly IPageModuleRepository _pageModules;
|
||||
private readonly IUserPermissions _userPermissions;
|
||||
private readonly ILogManager _logger;
|
||||
|
||||
public PageController(IPageRepository Pages, IModuleRepository Modules, IPageModuleRepository PageModules, IUserPermissions UserPermissions, ILogManager logger)
|
||||
{
|
||||
this.Pages = Pages;
|
||||
this.Modules = Modules;
|
||||
this.PageModules = PageModules;
|
||||
this.UserPermissions = UserPermissions;
|
||||
this.logger = logger;
|
||||
this._pages = Pages;
|
||||
this._modules = Modules;
|
||||
this._pageModules = PageModules;
|
||||
this._userPermissions = UserPermissions;
|
||||
this._logger = logger;
|
||||
}
|
||||
|
||||
// GET: api/<controller>?siteid=x
|
||||
@ -33,9 +33,9 @@ namespace Oqtane.Controllers
|
||||
public IEnumerable<Page> Get(string siteid)
|
||||
{
|
||||
List<Page> pages = new List<Page>();
|
||||
foreach (Page page in Pages.GetPages(int.Parse(siteid)))
|
||||
foreach (Page page in _pages.GetPages(int.Parse(siteid)))
|
||||
{
|
||||
if (UserPermissions.IsAuthorized(User, "View", page.Permissions))
|
||||
if (_userPermissions.IsAuthorized(User, "View", page.Permissions))
|
||||
{
|
||||
pages.Add(page);
|
||||
}
|
||||
@ -50,19 +50,19 @@ namespace Oqtane.Controllers
|
||||
Page page;
|
||||
if (string.IsNullOrEmpty(userid))
|
||||
{
|
||||
page = Pages.GetPage(id);
|
||||
page = _pages.GetPage(id);
|
||||
}
|
||||
else
|
||||
{
|
||||
page = Pages.GetPage(id, int.Parse(userid));
|
||||
page = _pages.GetPage(id, int.Parse(userid));
|
||||
}
|
||||
if (UserPermissions.IsAuthorized(User, "View", page.Permissions))
|
||||
if (_userPermissions.IsAuthorized(User, "View", page.Permissions))
|
||||
{
|
||||
return page;
|
||||
}
|
||||
else
|
||||
{
|
||||
logger.Log(LogLevel.Error, this, LogFunction.Read, "User Not Authorized To Access Page {Page}", page);
|
||||
_logger.Log(LogLevel.Error, this, LogFunction.Read, "User Not Authorized To Access Page {Page}", page);
|
||||
HttpContext.Response.StatusCode = 401;
|
||||
return null;
|
||||
}
|
||||
@ -78,21 +78,21 @@ namespace Oqtane.Controllers
|
||||
string permissions;
|
||||
if (Page.ParentId != null)
|
||||
{
|
||||
permissions = Pages.GetPage(Page.ParentId.Value).Permissions;
|
||||
permissions = _pages.GetPage(Page.ParentId.Value).Permissions;
|
||||
}
|
||||
else
|
||||
{
|
||||
permissions = UserSecurity.SetPermissionStrings(new List<PermissionString> { new PermissionString { PermissionName = "Edit", Permissions = Constants.AdminRole } });
|
||||
}
|
||||
|
||||
if (UserPermissions.IsAuthorized(User, "Edit", permissions))
|
||||
if (_userPermissions.IsAuthorized(User, "Edit", permissions))
|
||||
{
|
||||
Page = Pages.AddPage(Page);
|
||||
logger.Log(LogLevel.Information, this, LogFunction.Create, "Page Added {Page}", Page);
|
||||
Page = _pages.AddPage(Page);
|
||||
_logger.Log(LogLevel.Information, this, LogFunction.Create, "Page Added {Page}", Page);
|
||||
}
|
||||
else
|
||||
{
|
||||
logger.Log(LogLevel.Error, this, LogFunction.Create, "User Not Authorized To Add Page {Page}", Page);
|
||||
_logger.Log(LogLevel.Error, this, LogFunction.Create, "User Not Authorized To Add Page {Page}", Page);
|
||||
HttpContext.Response.StatusCode = 401;
|
||||
Page = null;
|
||||
}
|
||||
@ -106,8 +106,8 @@ namespace Oqtane.Controllers
|
||||
public Page Post(int id, string userid)
|
||||
{
|
||||
Page page = null;
|
||||
Page parent = Pages.GetPage(id);
|
||||
if (parent != null && parent.IsPersonalizable && UserPermissions.GetUser(User).UserId == int.Parse(userid))
|
||||
Page parent = _pages.GetPage(id);
|
||||
if (parent != null && parent.IsPersonalizable && _userPermissions.GetUser(User).UserId == int.Parse(userid))
|
||||
{
|
||||
page = new Page();
|
||||
page.SiteId = parent.SiteId;
|
||||
@ -126,10 +126,10 @@ namespace Oqtane.Controllers
|
||||
page.Permissions = UserSecurity.SetPermissionStrings(permissions);
|
||||
page.IsPersonalizable = false;
|
||||
page.UserId = int.Parse(userid);
|
||||
page = Pages.AddPage(page);
|
||||
page = _pages.AddPage(page);
|
||||
|
||||
// copy modules
|
||||
List<PageModule> pagemodules = PageModules.GetPageModules(page.SiteId).ToList();
|
||||
List<PageModule> pagemodules = _pageModules.GetPageModules(page.SiteId).ToList();
|
||||
foreach (PageModule pm in pagemodules.Where(item => item.PageId == parent.PageId && !item.IsDeleted))
|
||||
{
|
||||
Module module = new Module();
|
||||
@ -140,12 +140,12 @@ namespace Oqtane.Controllers
|
||||
permissions.Add(new PermissionString { PermissionName = "View", Permissions = "[" + userid + "]" });
|
||||
permissions.Add(new PermissionString { PermissionName = "Edit", Permissions = "[" + userid + "]" });
|
||||
module.Permissions = UserSecurity.SetPermissionStrings(permissions);
|
||||
module = Modules.AddModule(module);
|
||||
module = _modules.AddModule(module);
|
||||
|
||||
string content = Modules.ExportModule(pm.ModuleId);
|
||||
string content = _modules.ExportModule(pm.ModuleId);
|
||||
if (content != "")
|
||||
{
|
||||
Modules.ImportModule(module.ModuleId, content);
|
||||
_modules.ImportModule(module.ModuleId, content);
|
||||
}
|
||||
|
||||
PageModule pagemodule = new PageModule();
|
||||
@ -156,7 +156,7 @@ namespace Oqtane.Controllers
|
||||
pagemodule.Order = pm.Order;
|
||||
pagemodule.ContainerType = pm.ContainerType;
|
||||
|
||||
PageModules.AddPageModule(pagemodule);
|
||||
_pageModules.AddPageModule(pagemodule);
|
||||
}
|
||||
}
|
||||
return page;
|
||||
@ -167,14 +167,14 @@ namespace Oqtane.Controllers
|
||||
[Authorize(Roles = Constants.RegisteredRole)]
|
||||
public Page Put(int id, [FromBody] Page Page)
|
||||
{
|
||||
if (ModelState.IsValid && UserPermissions.IsAuthorized(User, "Page", Page.PageId, "Edit"))
|
||||
if (ModelState.IsValid && _userPermissions.IsAuthorized(User, "Page", Page.PageId, "Edit"))
|
||||
{
|
||||
Page = Pages.UpdatePage(Page);
|
||||
logger.Log(LogLevel.Information, this, LogFunction.Update, "Page Updated {Page}", Page);
|
||||
Page = _pages.UpdatePage(Page);
|
||||
_logger.Log(LogLevel.Information, this, LogFunction.Update, "Page Updated {Page}", Page);
|
||||
}
|
||||
else
|
||||
{
|
||||
logger.Log(LogLevel.Error, this, LogFunction.Update, "User Not Authorized To Update Page {Page}", Page);
|
||||
_logger.Log(LogLevel.Error, this, LogFunction.Update, "User Not Authorized To Update Page {Page}", Page);
|
||||
HttpContext.Response.StatusCode = 401;
|
||||
Page = null;
|
||||
}
|
||||
@ -186,24 +186,24 @@ namespace Oqtane.Controllers
|
||||
[Authorize(Roles = Constants.RegisteredRole)]
|
||||
public void Put(int siteid, int pageid, int? parentid)
|
||||
{
|
||||
if (UserPermissions.IsAuthorized(User, "Page", pageid, "Edit"))
|
||||
if (_userPermissions.IsAuthorized(User, "Page", pageid, "Edit"))
|
||||
{
|
||||
int order = 1;
|
||||
List<Page> pages = Pages.GetPages(siteid).ToList();
|
||||
List<Page> pages = _pages.GetPages(siteid).ToList();
|
||||
foreach (Page page in pages.Where(item => item.ParentId == parentid).OrderBy(item => item.Order))
|
||||
{
|
||||
if (page.Order != order)
|
||||
{
|
||||
page.Order = order;
|
||||
Pages.UpdatePage(page);
|
||||
_pages.UpdatePage(page);
|
||||
}
|
||||
order += 2;
|
||||
}
|
||||
logger.Log(LogLevel.Information, this, LogFunction.Update, "Page Order Updated {SiteId} {PageId} {ParentId}", siteid, pageid, parentid);
|
||||
_logger.Log(LogLevel.Information, this, LogFunction.Update, "Page Order Updated {SiteId} {PageId} {ParentId}", siteid, pageid, parentid);
|
||||
}
|
||||
else
|
||||
{
|
||||
logger.Log(LogLevel.Error, this, LogFunction.Update, "User Not Authorized To Update Page Order {SiteId} {PageId} {ParentId}", siteid, pageid, parentid);
|
||||
_logger.Log(LogLevel.Error, this, LogFunction.Update, "User Not Authorized To Update Page Order {SiteId} {PageId} {ParentId}", siteid, pageid, parentid);
|
||||
HttpContext.Response.StatusCode = 401;
|
||||
}
|
||||
}
|
||||
@ -213,14 +213,14 @@ namespace Oqtane.Controllers
|
||||
[Authorize(Roles = Constants.RegisteredRole)]
|
||||
public void Delete(int id)
|
||||
{
|
||||
if (UserPermissions.IsAuthorized(User, "Page", id, "Edit"))
|
||||
if (_userPermissions.IsAuthorized(User, "Page", id, "Edit"))
|
||||
{
|
||||
Pages.DeletePage(id);
|
||||
logger.Log(LogLevel.Information, this, LogFunction.Delete, "Page Deleted {PageId}", id);
|
||||
_pages.DeletePage(id);
|
||||
_logger.Log(LogLevel.Information, this, LogFunction.Delete, "Page Deleted {PageId}", id);
|
||||
}
|
||||
else
|
||||
{
|
||||
logger.Log(LogLevel.Error, this, LogFunction.Delete, "User Not Authorized To Delete Page {PageId}", id);
|
||||
_logger.Log(LogLevel.Error, this, LogFunction.Delete, "User Not Authorized To Delete Page {PageId}", id);
|
||||
HttpContext.Response.StatusCode = 401;
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user