exception handling needs to encapsulate entire method

This commit is contained in:
sbwalker
2025-09-05 11:13:21 -04:00
parent c698188901
commit e913c10d5b

View File

@ -114,14 +114,14 @@ else
private async Task StartJob(int jobId) private async Task StartJob(int jobId)
{ {
Job _job = await JobService.GetJobAsync(jobId); try
if (!_job.IsEnabled)
{ {
AddModuleMessage(Localizer["Message.Job.Disabled"], MessageType.Warning); Job _job = await JobService.GetJobAsync(jobId);
} if (!_job.IsEnabled)
else {
{ AddModuleMessage(Localizer["Message.Job.Disabled"], MessageType.Warning);
try }
else
{ {
await JobService.StartJobAsync(jobId); await JobService.StartJobAsync(jobId);
await logger.LogInformation("Job Started {JobId}", jobId); await logger.LogInformation("Job Started {JobId}", jobId);
@ -129,11 +129,11 @@ else
_jobs = await JobService.GetJobsAsync(); _jobs = await JobService.GetJobsAsync();
StateHasChanged(); StateHasChanged();
} }
catch (Exception ex) }
{ catch (Exception ex)
await logger.LogError(ex, "Error Starting Job {JobId} {Error}", jobId, ex.Message); {
AddModuleMessage(Localizer["Error.Job.Start"], MessageType.Error); await logger.LogError(ex, "Error Starting Job {JobId} {Error}", jobId, ex.Message);
} AddModuleMessage(Localizer["Error.Job.Start"], MessageType.Error);
} }
} }