From c3b1bc66749f6c243e8c3296251ee8d3e13ac05e Mon Sep 17 00:00:00 2001
From: sbwalker <shaun.walker@siliqon.com>
Date: Wed, 22 Nov 2023 15:36:49 -0500
Subject: [PATCH] only display Authorization Response Type option for
 OpenIDConnect and fix missing localization

---
 Oqtane.Client/Modules/Admin/Users/Index.razor | 31 ++++++++++---------
 .../Resources/Modules/Admin/Users/Index.resx  | 23 ++++++++------
 2 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/Oqtane.Client/Modules/Admin/Users/Index.razor b/Oqtane.Client/Modules/Admin/Users/Index.razor
index 82862c12..e994a4dc 100644
--- a/Oqtane.Client/Modules/Admin/Users/Index.razor
+++ b/Oqtane.Client/Modules/Admin/Users/Index.razor
@@ -266,21 +266,24 @@ else
 									<input id="parameters" class="form-control" @bind="@_parameters" />
 								</div>
 							</div>
-                            <div class="row mb-1 align-items-center">
-                                <Label Class="col-sm-3" For="authresponsetype" HelpText="Specify the authorization response type" ResourceKey="AuthResponseType">Authorization Response Type</Label>
-                                <div class="col-sm-9">
-                                    <select id="authresponsetype" class="form-select" @bind="@_authresponsetype" required>
-                                        <option value="code">@Localizer["AuthFlow.Code"]</option>
-                                        <option value="code id_token">@Localizer["AuthFlow.CodeIdToken"]</option>
-                                        <option value="code id_token token">@Localizer["AuthFlow.CodeIdTokenToken"]</option>
-                                        <option value="code token">@Localizer["AuthFlow.CodeToken"]</option>
-                                        <option value="id_token">@Localizer["AuthFlow.IdToken"]</option>
-                                        <option value="id_token token">@Localizer["AuthFlow.IdTokenToken"]</option>
-                                        <option value="token">@Localizer["AuthFlow.Token"]</option>
-                                        <option value="none">@Localizer["AuthFlow.None"]</option>
-                                    </select>
+							@if (_providertype == AuthenticationProviderTypes.OpenIDConnect)
+                            {
+                                <div class="row mb-1 align-items-center">
+                                    <Label Class="col-sm-3" For="authresponsetype" HelpText="Specify the authorization response type. The default is Authorization Code which is considered to be the most secure option based on the latest OAuth specification." ResourceKey="AuthResponseType">Authorization Response Type:</Label>
+                                    <div class="col-sm-9">
+                                        <select id="authresponsetype" class="form-select" @bind="@_authresponsetype" required>
+                                            <option value="code">@Localizer["AuthFlow.Code"]</option>
+                                            <option value="code id_token">@Localizer["AuthFlow.CodeIdToken"]</option>
+                                            <option value="code id_token token">@Localizer["AuthFlow.CodeIdTokenToken"]</option>
+                                            <option value="code token">@Localizer["AuthFlow.CodeToken"]</option>
+                                            <option value="id_token">@Localizer["AuthFlow.IdToken"]</option>
+                                            <option value="id_token token">@Localizer["AuthFlow.IdTokenToken"]</option>
+                                            <option value="token">@Localizer["AuthFlow.Token"]</option>
+                                            <option value="none">@Localizer["AuthFlow.None"]</option>
+                                        </select>
+                                    </div>
                                 </div>
-                            </div>
+                            }
                             <div class="row mb-1 align-items-center">
 								<Label Class="col-sm-3" For="pkce" HelpText="Indicate if the provider supports Proof Key for Code Exchange (PKCE)" ResourceKey="PKCE">Use PKCE?</Label>
 								<div class="col-sm-9">
diff --git a/Oqtane.Client/Resources/Modules/Admin/Users/Index.resx b/Oqtane.Client/Resources/Modules/Admin/Users/Index.resx
index e6d4792b..d40eebc8 100644
--- a/Oqtane.Client/Resources/Modules/Admin/Users/Index.resx
+++ b/Oqtane.Client/Resources/Modules/Admin/Users/Index.resx
@@ -409,31 +409,34 @@
     <value>Import Users</value>
   </data>
   <data name="AuthFlow.Code" xml:space="preserve">
-    <value>code</value>
+    <value>Authorization Code</value>
   </data>
   <data name="AuthFlow.CodeIdToken" xml:space="preserve">
-    <value>code id_token</value>
+    <value>Authorization Code + ID Token</value>
   </data>
   <data name="AuthFlow.CodeIdTokenToken" xml:space="preserve">
-    <value>code id_token token</value>
+    <value>Authorization Code + ID Token + Access Token</value>
   </data>
   <data name="AuthFlow.CodeToken" xml:space="preserve">
-    <value>code token</value>
+    <value>Authorization Code + Access Token</value>
   </data>
   <data name="AuthFlow.IdToken" xml:space="preserve">
-    <value>id_token</value>
+    <value>ID Token</value>
   </data>
   <data name="AuthFlow.IdTokenToken" xml:space="preserve">
-    <value>id_token token</value>
+    <value>ID Token + Access Token</value>
   </data>
   <data name="AuthFlow.None" xml:space="preserve">
-    <value>none</value>
+    <value>None</value>
   </data>
   <data name="AuthFlow.Token" xml:space="preserve">
-    <value>token</value>
+    <value>Access Token</value>
   </data>
-  <data name="AuthResponseType" xml:space="preserve">
-    <value>Authorization Response Type</value>
+  <data name="AuthResponseType.Text" xml:space="preserve">
+    <value>Authorization Response Type:</value>
+  </data>
+  <data name="AuthResponseType.HelpText" xml:space="preserve">
+    <value>Specify the authorization response type. The default is Authorization Code which is considered to be the most secure option based on the latest OAuth specification.</value>
   </data>
   <data name="VerifyUsers.HelpText" xml:space="preserve">
     <value>Do you want existing users to perform an additional email verification step to link their external login? If you disable this option, existing users will be linked automatically.</value>