From 52bcdb12c5d112b0ebbdd73b4a33bd3ef49aa128 Mon Sep 17 00:00:00 2001 From: Shaun Walker Date: Thu, 24 Jun 2021 18:02:01 -0400 Subject: [PATCH 1/4] package management modifications --- .../Modules/Admin/ModuleDefinitions/Add.razor | 92 ++++++++++--------- Oqtane.Client/Modules/Admin/Themes/Add.razor | 92 ++++++++++--------- .../Modules/Admin/Upgrade/Index.razor | 57 ++++++------ Oqtane.Client/UI/SiteRouter.razor | 9 +- Oqtane.Package/release.cmd | 1 + 5 files changed, 126 insertions(+), 125 deletions(-) diff --git a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor index 115294e7..6d31270f 100644 --- a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor +++ b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor @@ -7,57 +7,58 @@ @inject IStringLocalizer Localizer @inject IStringLocalizer SharedLocalizer -@if (_packages != null) -{ - - @if (_packages.Count > 0) + + + @if (_packages != null && _packages.Count > 0) { - - + - - - - - -
- - -   - -
- - - - -

@context.Name

  by:  @context.Owner
- @(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
- @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version - - - - -
-
-
- } - - +
- + - +   +
-
-
- - @Localizer["Cancel"] -} + + + +

@context.Name

  by:  @context.Owner
+ @(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
+ @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version + + + + +
+
+ } + else + { + + } + + + + + + + +
+ + + +
+
+
+ + +@Localizer["Cancel"] @code { private List _packages; @@ -83,11 +84,14 @@ var moduledefinitions = await ModuleDefinitionService.GetModuleDefinitionsAsync(PageState.Site.SiteId); _packages = await PackageService.GetPackagesAsync("module", _search); - foreach (Package package in _packages.ToArray()) + if (_packages != null) { - if (moduledefinitions.Exists(item => item.PackageName == package.PackageId)) + foreach (Package package in _packages.ToArray()) { - _packages.Remove(package); + if (moduledefinitions.Exists(item => item.PackageName == package.PackageId)) + { + _packages.Remove(package); + } } } } diff --git a/Oqtane.Client/Modules/Admin/Themes/Add.razor b/Oqtane.Client/Modules/Admin/Themes/Add.razor index 0866821d..5b4d063e 100644 --- a/Oqtane.Client/Modules/Admin/Themes/Add.razor +++ b/Oqtane.Client/Modules/Admin/Themes/Add.razor @@ -7,57 +7,58 @@ @inject IStringLocalizer Localizer @inject IStringLocalizer SharedLocalizer -@if (_packages != null) -{ - - @if (_packages.Count > 0) + + + @if (_packages != null && _packages.Count > 0) { - - + - - - - - -
- - -   - -
- - - - -

@context.Name

  @SharedLocalizer["Search.By"]:  @context.Owner
- @(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
- @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version - - - - -
-
-
- } - - +
- + - +   +
-
-
- - @Localizer["Cancel"] -} + + + +

@context.Name

  @SharedLocalizer["Search.By"]:  @context.Owner
+ @(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
+ @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version + + + + +
+
+ } + else + { + + } + + + + + + + +
+ + + +
+
+
+ + +@Localizer["Cancel"] @code { private List _packages; @@ -83,11 +84,14 @@ var themes = await ThemeService.GetThemesAsync(); _packages = await PackageService.GetPackagesAsync("theme", _search); - foreach (Package package in _packages.ToArray()) + if (_packages != null) { - if (themes.Exists(item => item.PackageName == package.PackageId)) + foreach (Package package in _packages.ToArray()) { - _packages.Remove(package); + if (themes.Exists(item => item.PackageName == package.PackageId)) + { + _packages.Remove(package); + } } } } diff --git a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor index ceb379d5..aabf6a5e 100644 --- a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor +++ b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor @@ -6,37 +6,34 @@ @inject IInstallationService InstallationService @inject IStringLocalizer Localizer -@if (_package != null) -{ - - - @if (_upgradeavailable) - { - - - - } - else - { - - } - - - - - - - - -
- - - -
+ + + @if (_package != null && _upgradeavailable) + { + + - - -} + } + else + { + + } +
+ + + + + + + +
+ + + +
+ +
+
@code { private Package _package; diff --git a/Oqtane.Client/UI/SiteRouter.razor b/Oqtane.Client/UI/SiteRouter.razor index cbe7783a..629e6078 100644 --- a/Oqtane.Client/UI/SiteRouter.razor +++ b/Oqtane.Client/UI/SiteRouter.razor @@ -172,13 +172,8 @@ } // format path and remove alias - path = path.Replace("//", "/"); - - if (!path.EndsWith("/")) - { - path += "/"; - } - + path = path.Replace("//", "/"); // in case of doubleslash at end + path += (!path.EndsWith("/")) ? "/" : ""; if (SiteState.Alias.Path != "" && path.StartsWith(SiteState.Alias.Path)) { path = path.Substring(SiteState.Alias.Path.Length + 1); diff --git a/Oqtane.Package/release.cmd b/Oqtane.Package/release.cmd index bd1b9784..1725d0a4 100644 --- a/Oqtane.Package/release.cmd +++ b/Oqtane.Package/release.cmd @@ -1,4 +1,5 @@ del "*.nupkg" +del "*.zip" dotnet clean -c Release ..\Oqtane.sln dotnet build -c Release ..\Oqtane.sln copy /Y/B/V "..\Oqtane.Server\bin\Release\net5.0\System.Drawing.Common.dll" "..\Oqtane.Server\bin\Release\net5.0\publish\System.Drawing.Common.dll" From 509f0549617ddb83c7a5d8a533cd4c4b4a1261e4 Mon Sep 17 00:00:00 2001 From: Shaun Walker Date: Fri, 25 Jun 2021 08:10:15 -0400 Subject: [PATCH 2/4] package UI updates --- Oqtane.Client/Modules/Admin/Languages/Add.razor | 2 +- Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor | 2 +- Oqtane.Client/Modules/Admin/SystemInfo/Index.razor | 2 +- Oqtane.Client/Modules/Admin/Themes/Add.razor | 2 +- Oqtane.Client/Modules/Admin/Upgrade/Index.razor | 2 +- Oqtane.Client/Resources/SharedResources.resx | 5 ++++- Oqtane.Server/Controllers/PackageController.cs | 1 - 7 files changed, 9 insertions(+), 7 deletions(-) diff --git a/Oqtane.Client/Modules/Admin/Languages/Add.razor b/Oqtane.Client/Modules/Admin/Languages/Add.razor index 0c936c33..24a90b6a 100644 --- a/Oqtane.Client/Modules/Admin/Languages/Add.razor +++ b/Oqtane.Client/Modules/Admin/Languages/Add.razor @@ -75,7 +75,7 @@ else

@context.Name

  by:  @context.Owner
@(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
- @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version + @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version  |  @SharedLocalizer["Search.Source"]: @context.PackageUrl diff --git a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor index 6d31270f..f4cb7680 100644 --- a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor +++ b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor @@ -30,7 +30,7 @@

@context.Name

  by:  @context.Owner
@(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
- @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version + @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version  |  @SharedLocalizer["Search.Source"]: @context.PackageUrl diff --git a/Oqtane.Client/Modules/Admin/SystemInfo/Index.razor b/Oqtane.Client/Modules/Admin/SystemInfo/Index.razor index 1d8fda36..a39d3fac 100644 --- a/Oqtane.Client/Modules/Admin/SystemInfo/Index.razor +++ b/Oqtane.Client/Modules/Admin/SystemInfo/Index.razor @@ -122,7 +122,7 @@ { ShowProgressIndicator(); var interop = new Interop(JSRuntime); - await interop.RedirectBrowser(NavigateUrl(""), 10); + await interop.RedirectBrowser(NavigateUrl(""), 20); await InstallationService.RestartAsync(); } catch (Exception ex) diff --git a/Oqtane.Client/Modules/Admin/Themes/Add.razor b/Oqtane.Client/Modules/Admin/Themes/Add.razor index 5b4d063e..1ef14328 100644 --- a/Oqtane.Client/Modules/Admin/Themes/Add.razor +++ b/Oqtane.Client/Modules/Admin/Themes/Add.razor @@ -30,7 +30,7 @@

@context.Name

  @SharedLocalizer["Search.By"]:  @context.Owner
@(context.Description.Length > 400 ? (context.Description.Substring(0, 400) + "...") : context.Description)
- @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version + @(String.Format("{0:n0}", context.Downloads)) @SharedLocalizer["Search.Downloads"]  |   @SharedLocalizer["Search.Released"]: @context.ReleaseDate.ToString("MMM dd, yyyy")  |  @SharedLocalizer["Search.Version"]: @context.Version  |  @SharedLocalizer["Search.Source"]: @context.PackageUrl diff --git a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor index aabf6a5e..d396f1bd 100644 --- a/Oqtane.Client/Modules/Admin/Upgrade/Index.razor +++ b/Oqtane.Client/Modules/Admin/Upgrade/Index.razor @@ -72,7 +72,7 @@ AddModuleMessage(Localizer["Info.Upgrade.Wait"], MessageType.Info); ShowProgressIndicator(); var interop = new Interop(JSRuntime); - await interop.RedirectBrowser(NavigateUrl(), 30); + await interop.RedirectBrowser(NavigateUrl(), 20); await InstallationService.Upgrade(); } catch (Exception ex) diff --git a/Oqtane.Client/Resources/SharedResources.resx b/Oqtane.Client/Resources/SharedResources.resx index 6f0687b7..980729e1 100644 --- a/Oqtane.Client/Resources/SharedResources.resx +++ b/Oqtane.Client/Resources/SharedResources.resx @@ -226,9 +226,12 @@ downloads - release date + released version + + source + \ No newline at end of file diff --git a/Oqtane.Server/Controllers/PackageController.cs b/Oqtane.Server/Controllers/PackageController.cs index f775f9b7..8887e42f 100644 --- a/Oqtane.Server/Controllers/PackageController.cs +++ b/Oqtane.Server/Controllers/PackageController.cs @@ -34,7 +34,6 @@ namespace Oqtane.Controllers // GET: api/?type=x&search=y [HttpGet] - [Authorize(Roles = RoleNames.Host)] public async Task> Get(string type, string search) { // get packages From e1e4d826849fdc0fc3b322212394c3dc7c4c6ee8 Mon Sep 17 00:00:00 2001 From: Shaun Walker Date: Fri, 25 Jun 2021 08:22:36 -0400 Subject: [PATCH 3/4] resx file corrections --- Oqtane.Client/Modules/Admin/Languages/Add.razor | 4 ---- Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor | 4 ---- Oqtane.Client/Modules/Admin/Themes/Add.razor | 4 ---- Oqtane.Client/Resources/Modules/Admin/Languages/Add.resx | 2 +- Oqtane.Client/Resources/Modules/Admin/Languages/Index.resx | 2 +- .../Resources/Modules/Admin/ModuleCreator/Index.resx | 4 ++-- .../Resources/Modules/Admin/ModuleDefinitions/Add.resx | 2 +- .../Resources/Modules/Admin/ModuleDefinitions/Create.resx | 4 ++-- .../Resources/Modules/Admin/ModuleDefinitions/Index.resx | 4 ++-- Oqtane.Client/Resources/Modules/Admin/Themes/Add.resx | 2 +- Oqtane.Client/Resources/Modules/Admin/Themes/Create.resx | 4 ++-- Oqtane.Client/Resources/Modules/Admin/Themes/Index.resx | 4 ++-- 12 files changed, 14 insertions(+), 26 deletions(-) diff --git a/Oqtane.Client/Modules/Admin/Languages/Add.razor b/Oqtane.Client/Modules/Admin/Languages/Add.razor index 24a90b6a..2c3eea33 100644 --- a/Oqtane.Client/Modules/Admin/Languages/Add.razor +++ b/Oqtane.Client/Modules/Admin/Languages/Add.razor @@ -85,10 +85,6 @@ else @Localizer["Cancel"] } - else - { - - } diff --git a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor index f4cb7680..803fd7ca 100644 --- a/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor +++ b/Oqtane.Client/Modules/Admin/ModuleDefinitions/Add.razor @@ -38,10 +38,6 @@ } - else - { - - }
diff --git a/Oqtane.Client/Modules/Admin/Themes/Add.razor b/Oqtane.Client/Modules/Admin/Themes/Add.razor index 1ef14328..7c71b494 100644 --- a/Oqtane.Client/Modules/Admin/Themes/Add.razor +++ b/Oqtane.Client/Modules/Admin/Themes/Add.razor @@ -38,10 +38,6 @@ } - else - { - - }
diff --git a/Oqtane.Client/Resources/Modules/Admin/Languages/Add.resx b/Oqtane.Client/Resources/Modules/Admin/Languages/Add.resx index 5b11d69f..e3ea4a00 100644 --- a/Oqtane.Client/Resources/Modules/Admin/Languages/Add.resx +++ b/Oqtane.Client/Resources/Modules/Admin/Languages/Add.resx @@ -166,6 +166,6 @@ Translation Downloaded Successfully. Click Install To Complete Installation. - Translations Installed Successfully. You Must <a href=\"{0}\">Restart</a> Your Application To Apply These Changes. + Translations Installed Successfully. You Must <a href={0}>Restart</a> Your Application To Apply These Changes. \ No newline at end of file diff --git a/Oqtane.Client/Resources/Modules/Admin/Languages/Index.resx b/Oqtane.Client/Resources/Modules/Admin/Languages/Index.resx index e62f8156..8545439e 100644 --- a/Oqtane.Client/Resources/Modules/Admin/Languages/Index.resx +++ b/Oqtane.Client/Resources/Modules/Admin/Languages/Index.resx @@ -145,7 +145,7 @@ Error Downloading Translation - Translation Installed Successfully. You Must <a href=\"{0}\">Restart</a> Your Application To Apply These Changes. + Translation Installed Successfully. You Must <a href={0}>Restart</a> Your Application To Apply These Changes. Upgrade diff --git a/Oqtane.Client/Resources/Modules/Admin/ModuleCreator/Index.resx b/Oqtane.Client/Resources/Modules/Admin/ModuleCreator/Index.resx index 61d8cda8..6f9d702f 100644 --- a/Oqtane.Client/Resources/Modules/Admin/ModuleCreator/Index.resx +++ b/Oqtane.Client/Resources/Modules/Admin/ModuleCreator/Index.resx @@ -1,4 +1,4 @@ - +