From 49e69d3c3e66ae15c8e7177b1220ee39d2732dff Mon Sep 17 00:00:00 2001 From: Emanuele Filardo Date: Sat, 8 Feb 2020 00:34:16 +0100 Subject: [PATCH 1/3] Fix .net core version in Upgrade project --- Oqtane.Upgrade/Oqtane.Upgrade.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Oqtane.Upgrade/Oqtane.Upgrade.csproj b/Oqtane.Upgrade/Oqtane.Upgrade.csproj index 0ddddf67..3e32c64c 100644 --- a/Oqtane.Upgrade/Oqtane.Upgrade.csproj +++ b/Oqtane.Upgrade/Oqtane.Upgrade.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.0 + netcoreapp3.1 From b012a0dcaafc45771cc76e0c17d089bd3d6ebef9 Mon Sep 17 00:00:00 2001 From: Pavel Vesely Date: Sat, 8 Feb 2020 17:35:27 +0100 Subject: [PATCH 2/3] Missing nullchecks -> unhandled exceptions --- Oqtane.Client/Shared/ModuleInstance.razor | 20 +++++++++++++------- Oqtane.Client/Shared/SiteRouter.razor | 2 +- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/Oqtane.Client/Shared/ModuleInstance.razor b/Oqtane.Client/Shared/ModuleInstance.razor index c6ae4a23..8d563405 100644 --- a/Oqtane.Client/Shared/ModuleInstance.razor +++ b/Oqtane.Client/Shared/ModuleInstance.razor @@ -39,17 +39,23 @@ if (typename != null) { moduleType = Type.GetType(typename); - } - if (moduleType != null) - { - builder.OpenComponent(0, moduleType); - builder.CloseComponent(); + + if (moduleType != null) + { + builder.OpenComponent(0, moduleType); + builder.CloseComponent(); + } + else + { + // module does not exist with typename specified + message = "Module Does Not Have A Component Named " + Utilities.GetTypeNameLastSegment(typename, 0) + ".razor"; + } } else { - // module does not exist with typename specified - message = "Module Does Not Have A Component Named " + Utilities.GetTypeNameLastSegment(typename, 0) + ".razor"; + message = "Something is wrong with moduletype"; } + }; } diff --git a/Oqtane.Client/Shared/SiteRouter.razor b/Oqtane.Client/Shared/SiteRouter.razor index 4b63f2b6..95d67998 100644 --- a/Oqtane.Client/Shared/SiteRouter.razor +++ b/Oqtane.Client/Shared/SiteRouter.razor @@ -408,7 +408,7 @@ if (module.PageId == pageid) { // ensure module's pane exists in current page and if not, assign it to the Admin pane - if (!panes.ToLower().Contains(module.Pane.ToLower())) + if (panes == null || !panes.ToLower().Contains(module.Pane.ToLower())) { module.Pane = Constants.AdminPane; } From c76ffa1714f5aed2a96fa3a2fe3d66b2a151df21 Mon Sep 17 00:00:00 2001 From: Pavel Vesely Date: Sat, 8 Feb 2020 22:48:00 +0100 Subject: [PATCH 3/3] Save Site SMTP settings bug --- Oqtane.Client/Modules/Admin/Sites/Edit.razor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Oqtane.Client/Modules/Admin/Sites/Edit.razor b/Oqtane.Client/Modules/Admin/Sites/Edit.razor index 42c0e108..2f2e8ae9 100644 --- a/Oqtane.Client/Modules/Admin/Sites/Edit.razor +++ b/Oqtane.Client/Modules/Admin/Sites/Edit.razor @@ -299,7 +299,7 @@ else SettingService.SetSetting(settings, "SMTPSSL", smtpssl); SettingService.SetSetting(settings, "SMTPUsername", smtpusername); SettingService.SetSetting(settings, "SMTPPassword", smtppassword); - await SettingService.UpdateModuleSettingsAsync(settings, site.SiteId); + await SettingService.UpdateSiteSettingsAsync(settings, site.SiteId); await logger.LogInformation("Site Saved {Site}", site);