Merge pull request #354 from sbwalker/master

NavigateUrl fix to deal with scenario where alias has a value and path is ""
This commit is contained in:
Shaun Walker 2020-04-08 13:35:52 -04:00 committed by GitHub
commit 728bd23f5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 8 deletions

View File

@ -26,9 +26,8 @@
} }
@code { @code {
public override SecurityAccessLevel SecurityAccessLevel => SecurityAccessLevel.Edit;
public override SecurityAccessLevel SecurityAccessLevel { get { return SecurityAccessLevel.Edit; } } public override string Actions => "Add,Edit";
public override string Actions { get { return "Add,Edit"; } }
int _id; int _id;
string _name; string _name;

View File

@ -14,7 +14,7 @@
</table> </table>
@code { @code {
public override string Title { get { return "[Module] Settings"; } } public override string Title => "[Module] Settings";
string _value; string _value;

View File

@ -20,7 +20,9 @@ namespace Oqtane.Shared
var uriBuilder = new UriBuilder var uriBuilder = new UriBuilder
{ {
Path = !string.IsNullOrEmpty(alias) Path = !string.IsNullOrEmpty(alias)
? $"{alias}/{path}" ? (!string.IsNullOrEmpty(path))
? $"{alias}/{path}"
: $"{alias}"
: $"{path}", : $"{path}",
Query = parameters Query = parameters
}; };

View File

@ -10,11 +10,11 @@ namespace Oqtane.Test.Oqtane.Shared.Tests
[InlineData("contoso", "admin", "", "/contoso/admin")] [InlineData("contoso", "admin", "", "/contoso/admin")]
[InlineData("contoso", "", "pageId=4", "/contoso?pageId=4")] [InlineData("contoso", "", "pageId=4", "/contoso?pageId=4")]
[InlineData("contoso", "", "pageId=4&moduleId=10", "/contoso?pageId=4&moduleId=10")] [InlineData("contoso", "", "pageId=4&moduleId=10", "/contoso?pageId=4&moduleId=10")]
[InlineData("contoso", "", "", "/contoso/")] [InlineData("contoso", "", "", "/contoso")]
[InlineData("", "login", "returnUrl=/admin", "/login?returnUrl=/admin")] [InlineData("", "login", "returnUrl=/admin", "/login?returnUrl=/admin")]
[InlineData("", "admin", "", "/admin")] [InlineData("", "admin", "", "/admin")]
[InlineData("", "", "pageId=4", "?pageId=4")] [InlineData("", "", "pageId=4", "/?pageId=4")]
[InlineData("", "", "pageId=4&moduleId=10", "?pageId=4&moduleId=10")] [InlineData("", "", "pageId=4&moduleId=10", "/?pageId=4&moduleId=10")]
[InlineData("", "", "", "/")] [InlineData("", "", "", "/")]
public void NavigateUrlTest(string alias, string path, string parameters, string expectedUrl) public void NavigateUrlTest(string alias, string path, string parameters, string expectedUrl)
{ {

BIN
nuget.exe Normal file

Binary file not shown.