Merge pull request #3892 from zyhfish/task/revert-pr-3875

Revert "removed AddModuleMessage from OnParametersSetAsync methods to mitigate risk of infinite loops"
This commit is contained in:
Shaun Walker 2024-02-25 09:33:27 -05:00 committed by GitHub
commit c110611d82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 5 additions and 0 deletions

View File

@ -75,6 +75,7 @@
catch (Exception ex) catch (Exception ex)
{ {
await logger.LogError(ex, "Error Loading Files {Error}", ex.Message); await logger.LogError(ex, "Error Loading Files {Error}", ex.Message);
AddModuleMessage(Localizer["Error.File.Load"], MessageType.Error);
} }
} }

View File

@ -131,6 +131,7 @@ else
catch (Exception ex) catch (Exception ex)
{ {
await logger.LogError(ex, "Error Loading Logs {Error}", ex.Message); await logger.LogError(ex, "Error Loading Logs {Error}", ex.Message);
AddModuleMessage(Localizer["Error.Log.Load"], MessageType.Error);
} }
} }

View File

@ -120,6 +120,7 @@ else
if (_moduleDefinitions == null) if (_moduleDefinitions == null)
{ {
await logger.LogError(ex, "Error Loading Modules {Error}", ex.Message); await logger.LogError(ex, "Error Loading Modules {Error}", ex.Message);
AddModuleMessage(Localizer["Error.Module.Load"], MessageType.Error);
} }
} }
} }

View File

@ -86,6 +86,7 @@ else
if (_themes == null) if (_themes == null)
{ {
await logger.LogError(ex, "Error Loading Themes {Error}", ex.Message); await logger.LogError(ex, "Error Loading Themes {Error}", ex.Message);
AddModuleMessage(Localizer["Error.Theme.Load"], MessageType.Error);
} }
} }
} }

View File

@ -36,6 +36,7 @@
catch (Exception ex) catch (Exception ex)
{ {
await logger.LogError(ex, "Error Loading Content {Error}", ex.Message); await logger.LogError(ex, "Error Loading Content {Error}", ex.Message);
AddModuleMessage(Localizer["Error.Content.Load"], MessageType.Error);
} }
} }
} }