From 0a22f80942077349708e3e2295a3da2a80695868 Mon Sep 17 00:00:00 2001 From: sbwalker Date: Thu, 24 Aug 2023 08:09:53 -0400 Subject: [PATCH] added defensive logic to resolve regression issue caused by #3175 --- Oqtane.Server/Repository/ModuleDefinitionRepository.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Oqtane.Server/Repository/ModuleDefinitionRepository.cs b/Oqtane.Server/Repository/ModuleDefinitionRepository.cs index 57707c58..69df211f 100644 --- a/Oqtane.Server/Repository/ModuleDefinitionRepository.cs +++ b/Oqtane.Server/Repository/ModuleDefinitionRepository.cs @@ -145,7 +145,7 @@ namespace Oqtane.Repository moduledefinition = new ModuleDefinition { ModuleDefinitionName = ModuleDefinition.ModuleDefinitionName, Version = ModuleDefinition.Version }; _db.ModuleDefinition.Add(moduledefinition); _db.SaveChanges(); - ModuleDefinition.Version = ""; // ensure migrations are executed during startup + ModuleDefinition.Version = ""; // ensure migrations are executed during startup for new module installations } else { @@ -159,7 +159,7 @@ namespace Oqtane.Repository } // manage releaseversions in cases where it was not provided or is lower than the module version - if (string.IsNullOrEmpty(ModuleDefinition.ReleaseVersions) || Version.Parse(ModuleDefinition.Version).CompareTo(Version.Parse(ModuleDefinition.ReleaseVersions.Split(',').Last())) > 0) + if (string.IsNullOrEmpty(ModuleDefinition.ReleaseVersions) || (!string.IsNullOrEmpty(ModuleDefinition.Version) && Version.Parse(ModuleDefinition.Version).CompareTo(Version.Parse(ModuleDefinition.ReleaseVersions.Split(',').Last())) > 0)) { ModuleDefinition.ReleaseVersions = ModuleDefinition.Version; }