From df1d64608368d350f4748e31321246eebb4fea41 Mon Sep 17 00:00:00 2001
From: hishamco <hishamco_2007@yahoo.com>
Date: Tue, 8 Dec 2020 16:37:55 +0300
Subject: [PATCH] Refactor LocalizableComponent

---
 .../Modules/Controls/ActionDialog.razor       |  9 ++--
 .../Modules/Controls/ActionLink.razor         |  6 +--
 Oqtane.Client/Modules/Controls/Label.razor    |  4 +-
 .../Modules/Controls/LocalizableComponent.cs  | 46 ++++++++-----------
 Oqtane.Client/Modules/Controls/Section.razor  |  9 ++--
 Oqtane.Client/Modules/Controls/TabPanel.razor | 15 +++---
 6 files changed, 33 insertions(+), 56 deletions(-)

diff --git a/Oqtane.Client/Modules/Controls/ActionDialog.razor b/Oqtane.Client/Modules/Controls/ActionDialog.razor
index 4770729b..73723fa5 100644
--- a/Oqtane.Client/Modules/Controls/ActionDialog.razor
+++ b/Oqtane.Client/Modules/Controls/ActionDialog.razor
@@ -97,12 +97,9 @@
             _iconSpan = $"<span class=\"oi oi-{IconName}\"></span>&nbsp;";
         }
 
-        if (IsLocalizable)
-        {
-            Text = Localize(nameof(Text), Text);
-            Header = Localize(nameof(Header), Header);
-            Message = Localize(nameof(Message), Message);
-        }
+        Text = Localize(nameof(Text), Text);
+        Header = Localize(nameof(Header), Header);
+        Message = Localize(nameof(Message), Message);
 
         _authorized = IsAuthorized();
     }
diff --git a/Oqtane.Client/Modules/Controls/ActionLink.razor b/Oqtane.Client/Modules/Controls/ActionLink.razor
index eacc9813..1ba9ef12 100644
--- a/Oqtane.Client/Modules/Controls/ActionLink.razor
+++ b/Oqtane.Client/Modules/Controls/ActionLink.razor
@@ -95,11 +95,7 @@
 
         }
 
-        if (IsLocalizable)
-        {
-            _text = Localize(nameof(Text), _text);
-        }
-
+        _text = Localize(nameof(Text), _text);
         _url = EditUrl(Action, _parameters);
         _authorized = IsAuthorized();
     }
diff --git a/Oqtane.Client/Modules/Controls/Label.razor b/Oqtane.Client/Modules/Controls/Label.razor
index 85e65d14..05f2b790 100644
--- a/Oqtane.Client/Modules/Controls/Label.razor
+++ b/Oqtane.Client/Modules/Controls/Label.razor
@@ -45,11 +45,11 @@ else
 
         if (IsLocalizable)
         {
-            var value = Localize("Text");
             var key = $"{ResourceKey}.Text";
+            var value = Localize(key);
             if (!value.Equals(key))
             {
-                ChildContent =@<text>@Localize("Text")</text>;
+                ChildContent =@<text>@value</text>;
             }
 
             HelpText = Localize(nameof(HelpText), HelpText);
diff --git a/Oqtane.Client/Modules/Controls/LocalizableComponent.cs b/Oqtane.Client/Modules/Controls/LocalizableComponent.cs
index 657494d7..40f2eda5 100644
--- a/Oqtane.Client/Modules/Controls/LocalizableComponent.cs
+++ b/Oqtane.Client/Modules/Controls/LocalizableComponent.cs
@@ -15,27 +15,22 @@ namespace Oqtane.Modules.Controls
 
         protected bool IsLocalizable { get; private set; }
 
-        protected string Localize(string name)
-        {
-            var key = $"{ResourceKey}.{name}";
+        protected string Localize(string name) => _localizer?[name] ?? name;
 
-            // TODO: we should have a ShowMissingResourceKeys option which developers/translators can enable to find missing translations which would display the key rather than the name    
+        protected string Localize(string propertyName, string propertyValue)
+        {
             if (!IsLocalizable)
             {
-                return name;
+                return propertyValue;
             }
 
-            return _localizer?[key] ?? name;
-        }
-
-        protected string Localize(string name, string defaultValue)
-        {
-            var key = $"{ResourceKey}.{name}";
-            var value = Localize(name);
+            var key = $"{ResourceKey}.{propertyName}";
+            var value = Localize(key);
 
             if (value == key)
             {
-                return defaultValue;
+                // Returns default property value (English version) instead of ResourceKey.PropertyName
+                return propertyValue;
             }
             else
             {
@@ -45,26 +40,21 @@ namespace Oqtane.Modules.Controls
 
         protected override void OnParametersSet()
         {
-            if (!String.IsNullOrEmpty(ResourceKey))
+            IsLocalizable = false;
+
+            if (!String.IsNullOrEmpty(ResourceKey) && ModuleState?.ModuleType != null)
             {
-                if (ModuleState?.ModuleType != null)
+                var moduleType = Type.GetType(ModuleState.ModuleType);
+                if (moduleType != null)
                 {
-                    var moduleType = Type.GetType(ModuleState.ModuleType);
-                    if (moduleType != null)
+                    using (var scope = ServiceActivator.GetScope())
                     {
-                        using (var scope = ServiceActivator.GetScope())
-                        {
-                            var localizerFactory = scope.ServiceProvider.GetService<IStringLocalizerFactory>();
-                            _localizer = localizerFactory.Create(moduleType);
-                        }
+                        var localizerFactory = scope.ServiceProvider.GetService<IStringLocalizerFactory>();
+                        _localizer = localizerFactory.Create(moduleType);
+
+                        IsLocalizable = true;
                     }
                 }
-
-                IsLocalizable = true;
-            }
-            else
-            {
-                IsLocalizable = false;
             }
         }
     }
diff --git a/Oqtane.Client/Modules/Controls/Section.razor b/Oqtane.Client/Modules/Controls/Section.razor
index fd8b9a52..027b0e85 100644
--- a/Oqtane.Client/Modules/Controls/Section.razor
+++ b/Oqtane.Client/Modules/Controls/Section.razor
@@ -46,11 +46,8 @@
     {
         base.OnParametersSet();
 
-        if (IsLocalizable)
-        {
-            _heading = !string.IsNullOrEmpty(Heading)
-                ? Localize(nameof(Heading), Heading)
-                : Localize(nameof(Name), Name);
-        }
+        _heading = !string.IsNullOrEmpty(Heading)
+            ? Localize(nameof(Heading), Heading)
+            : Localize(nameof(Name), Name);
     }
 }
diff --git a/Oqtane.Client/Modules/Controls/TabPanel.razor b/Oqtane.Client/Modules/Controls/TabPanel.razor
index 7c2eaa24..e618c896 100644
--- a/Oqtane.Client/Modules/Controls/TabPanel.razor
+++ b/Oqtane.Client/Modules/Controls/TabPanel.razor
@@ -40,16 +40,13 @@ else
     {
         base.OnParametersSet();
 
-        if (IsLocalizable)
+        if (string.IsNullOrEmpty(Heading))
         {
-            if (string.IsNullOrEmpty(Heading))
-            {
-                Name = Localize(nameof(Name), Name);
-            }
-            else
-            {
-                Heading = Localize(nameof(Heading), Heading);
-            }
+            Name = Localize(nameof(Name), Name);
+        }
+        else
+        {
+            Heading = Localize(nameof(Heading), Heading);
         }
     }