From e01c3e7e4addcf6d57938ad6a895b2d0b8a70279 Mon Sep 17 00:00:00 2001
From: Shaun Walker <shaun.walker@siliqon.com>
Date: Thu, 29 Sep 2022 17:16:29 -0400
Subject: [PATCH] log any user creation errors from .NET Identity

---
 Oqtane.Server/Controllers/UserController.cs | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/Oqtane.Server/Controllers/UserController.cs b/Oqtane.Server/Controllers/UserController.cs
index 5f17f40c..4a2870e1 100644
--- a/Oqtane.Server/Controllers/UserController.cs
+++ b/Oqtane.Server/Controllers/UserController.cs
@@ -165,6 +165,7 @@ namespace Oqtane.Controllers
             if (allowregistration)
             {
                 bool succeeded;
+                string errors = "";
                 IdentityUser identityuser = await _identityUserManager.FindByNameAsync(user.Username);
                 if (identityuser == null)
                 {
@@ -174,12 +175,20 @@ namespace Oqtane.Controllers
                     identityuser.EmailConfirmed = verified;
                     var result = await _identityUserManager.CreateAsync(identityuser, user.Password);
                     succeeded = result.Succeeded;
+                    if (!succeeded)
+                    {
+                        errors = string.Join(", ", result.Errors.Select(e => e.Description));
+                    }
                 }
                 else
                 {
                     var result = await _identitySignInManager.CheckPasswordSignInAsync(identityuser, user.Password, false);
                     succeeded = result.Succeeded;
-                    verified = true;
+                    if (!succeeded)
+                    {
+                        errors = "Password Not Valid For User";
+                    }
+                    verified = succeeded;
                 }
 
                 if (succeeded)
@@ -188,6 +197,10 @@ namespace Oqtane.Controllers
                     user.LastIPAddress = "";
                     newUser = _users.AddUser(user);
                 }
+                else
+                {
+                    _logger.Log(user.SiteId, LogLevel.Error, this, LogFunction.Create, "Unable To Add User {Username} - {Errors}", user.Username, errors);
+                }
 
                 if (newUser != null)
                 {